linux-kernel - Re: [PATCH] staging: fbtft: Remove trailing semicolon in macro.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024073026-clubhouse-vividness-600d@gregkh>
Date: Tue, 30 Jul 2024 09:17:38 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Sakirnth Nagarasa <sakirnth@...il.com>
Cc: dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	~lkcamp/patches@...ts.sr.ht, helen.koike@...labora.com
Subject: Re: [PATCH] staging: fbtft: Remove trailing semicolon in macro.

On Tue, Jul 30, 2024 at 07:14:55AM +0000, Sakirnth Nagarasa wrote:
> Fix checkpath warning: "WARNING: macros should not use a trailing semicolon
> in fbtft.h:356.
> 
> Signed-off-by: Sakirnth Nagarasa <sakirnth@...il.com>
> 
> ---
> 
> Hello, this is my first patch to the kernel.
> ---
>  drivers/staging/fbtft/fbtft.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
> index f86ed9d47..45dfc92b8 100644
> --- a/drivers/staging/fbtft/fbtft.h
> +++ b/drivers/staging/fbtft/fbtft.h
> @@ -365,7 +365,7 @@ MODULE_DEVICE_TABLE(spi, spi_ids);						\
>  										\
>  FBTFT_SPI_DRIVER(_name, _comp_vend "," _comp_dev, _display, spi_ids)		\
>  										\
> -module_spi_driver(fbtft_driver_spi_driver);
> +module_spi_driver(fbtft_driver_spi_driver)

checkpatch is wrong here, the ';' is correct.

thanks,

greg k-h