linux-kernel - Re: [PATCH v5 4/5] media: platform: mediatek: isp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6bccc366-7b21-48a7-895e-d6693bac809d@web.de>
Date: Tue, 30 Jul 2024 09:25:45 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Florian Sylvestre <fsylvestre@...libre.com>,
 Julien Stephan <jstephan@...libre.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Paul Elder <paul.elder@...asonboard.com>,
 Phi-bang Nguyen <pnguyen@...libre.com>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-mediatek@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, Andy Hsieh <andy.hsieh@...iatek.com>,
 Angelo Gioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 4/5] media: platform: mediatek: isp_30: add mediatek
 ISP3.0 camsv

…
> +++ b/drivers/media/platform/mediatek/isp/isp_30/camsv/mtk_camsv30_hw.c
> @@ -0,0 +1,413 @@
…
> +static int mtk_camsv30_runtime_suspend(struct device *dev)
> +{
…
> +	if (vb2_is_streaming(vbq)) {
> +		mutex_lock(&cam_dev->op_lock);
> +		v4l2_subdev_call(&cam_dev->subdev, video, s_stream, 0);
> +		mutex_unlock(&cam_dev->op_lock);
> +	}
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&cam_dev->op_lock);”?
https://elixir.bootlin.com/linux/v6.10.2/source/include/linux/mutex.h#L196

Regards,
Markus