[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <37f1ecdc-9d98-4681-803a-75442fe04ab3@gmail.com>
Date: Tue, 30 Jul 2024 15:44:26 +0800
From: Hui-Ping Chen <hpchen0nvt@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, vkoul@...nel.org,
kishon@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: linux-arm-kernel@...ts.infradead.org, linux-phy@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: nuvoton,ma35-usb2-phy: add new
bindings
Dear Krzysztof,
Thank you for your reply.
On 2024/7/29 下午 03:29, Krzysztof Kozlowski wrote:
> On 29/07/2024 08:15, hpchen0 wrote:
>> Add dt-bindings for USB2 PHY found on the Nuvoton MA35 SoC.
>>
>> Signed-off-by: hpchen0 <hpchen0nvt@...il.com>
> Please use proper name.
Okay, I will make the correction and use the correct name.
>> ---
>> .../bindings/phy/nuvoton,ma35-usb2-phy.yaml | 51 +++++++++++++++++++
>> 1 file changed, 51 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/phy/nuvoton,ma35-usb2-phy.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/phy/nuvoton,ma35-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/nuvoton,ma35-usb2-phy.yaml
>> new file mode 100644
>> index 000000000000..415ea2c45975
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/nuvoton,ma35-usb2-phy.yaml
>> @@ -0,0 +1,51 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/phy/nuvoton,ma35-usb2-phy.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Nuvoton MA35 USB2 phy
>> +
>> +maintainers:
>> + - hpchen0 <hpchen0nvt@...il.com>
> Same here
Okay, I will make the correction and use the correct name.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - nuvoton,ma35-usb2-phy
> All other devices have name ma35d1. Is this a different SoC?
The SoC is the same as ma35d1. I will modify ma35 to ma35d1.
Originally, I intended to create a series of shared drivers.
>> +
>> + "#phy-cells":
>> + const: 0
>> +
>> + clocks:
>> + maxItems: 1
>> + description: USB PHY clock
> Drop description, it's obvious.
Okay, I will remove the description.
>> +
>> + clock-names:
>> + const: usbd_gate
> Drop clock-names, you do not bring any new information.
Okay, I will remove the clock-names.
>> +
>> + nuvoton,sys:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + phandle of the system-management node.
> Describe what is it for.
Because this driver has some status bits located in the sys, it is
necessary to reference the sys link.
>> +
>> +required:
>> + - compatible
>> + - clocks
>> + - nuvoton,sys
>> + - "#phy-cells"
> Keep the same order as in properties.
Okay, I will correct this issue.
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> Where do you use it?
This is not used and will be removed. Thanks for the reminder.
>> + #include <dt-bindings/clock/nuvoton,ma35d1-clk.h>
>> +
>> + usb_phy: usb-phy {
>> + compatible = "nuvoton,ma35-usb2-phy";
>> + clocks = <&clk USBD_GATE>;
>> + clock-names = "usbd_gate";
>> + nuvoton,sys = <&sys>;
>> + #phy-cells = <0>;
>> + };
> Best regards,
> Krzysztof
Best regards,
Hui-Ping Chen
Powered by blists - more mailing lists