linux-kernel - Re: [PATCH v2 1/2] riscv: dts: sophgo: Use common "interrupt-parent" for all peripherals for sg2042

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB2822A78958F1F3788C15FB5EFEB02@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Date: Tue, 30 Jul 2024 15:50:11 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Inochi Amaoto <inochiama@...look.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Guo Ren <guoren@...nel.org>, Arnd Bergmann <arnd@...db.de>,
 Chao Wei <chao.wei@...hgo.com>
Cc: devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] riscv: dts: sophgo: Use common "interrupt-parent"
 for all peripherals for sg2042


On 2024/7/29 10:13, Inochi Amaoto wrote:
> As all peripherals of sg2042 share the same "interrupt-parent",
> there is no need to use peripherals specific "interrupt-parent".
> Define "interrupt-parent" in the SoC level.
>
> Signed-off-by: Inochi Amaoto <inochiama@...look.com>

Reviewed-by: Chen Wang <unicorn_wang@...look.com>

Tested-by: Chen Wang <unicorn_wang@...look.com>

> ---
>   arch/riscv/boot/dts/sophgo/sg2042.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/sophgo/sg2042.dtsi b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> index 34c802bd3f9b..c61d8061119d 100644
> --- a/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> @@ -44,6 +44,7 @@ soc: soc {
>   		compatible = "simple-bus";
>   		#address-cells = <2>;
>   		#size-cells = <2>;
> +		interrupt-parent = <&intc>;
>   		ranges;
>
>   		pllclk: clock-controller@...00100c0 {
> @@ -388,7 +389,6 @@ rstgen: reset-controller@...0013000 {
>   		uart0: serial@...0000000 {
>   			compatible = "snps,dw-apb-uart";
>   			reg = <0x00000070 0x40000000 0x00000000 0x00001000>;
> -			interrupt-parent = <&intc>;
>   			interrupts = <112 IRQ_TYPE_LEVEL_HIGH>;
>   			clock-frequency = <500000000>;
>   			clocks = <&clkgen GATE_CLK_UART_500M>,
> --
> 2.45.2
>