linux-kernel - Re: [PATCH] usb: typec: tcpci: Fix error code in tcpci_check_std_output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZqinNYgseXFj3l7g@kuha.fi.intel.com>
Date: Tue, 30 Jul 2024 11:41:25 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Marco Felsch <m.felsch@...gutronix.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	RD Babiera <rdbabiera@...gle.com>,
	Guenter Roeck <linux@...ck-us.net>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] usb: typec: tcpci: Fix error code in
 tcpci_check_std_output_cap()

On Fri, Jul 12, 2024 at 09:05:50AM -0500, Dan Carpenter wrote:
> The tcpci_check_std_output_cap() function is supposed to return negative
> error codes but it's declared as type bool so the error handling doesn't
> work.  Declare it as an int instead.
> 
> Fixes: 62ce9ef14797 ("usb: typec: tcpci: add support to set connector orientation")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/tcpm/tcpci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c
> index 8a18d561b063..b5e49af48f43 100644
> --- a/drivers/usb/typec/tcpm/tcpci.c
> +++ b/drivers/usb/typec/tcpm/tcpci.c
> @@ -67,7 +67,7 @@ static int tcpci_write16(struct tcpci *tcpci, unsigned int reg, u16 val)
>  	return regmap_raw_write(tcpci->regmap, reg, &val, sizeof(u16));
>  }
>  
> -static bool tcpci_check_std_output_cap(struct regmap *regmap, u8 mask)
> +static int tcpci_check_std_output_cap(struct regmap *regmap, u8 mask)
>  {
>  	unsigned int reg;
>  	int ret;
> -- 
> 2.43.0

-- 
heikki