linux-kernel - Re: [PATCH 06/11] usb: typec: ucsi: Add qcom,sm7325-pmic-glink as needing PDOS quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ba4c7c6-9d48-49bc-b25d-c38aad7db016@kernel.org>
Date: Tue, 30 Jul 2024 11:04:01 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Danila Tikhonov <danila@...xyga.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, andersson@...nel.org,
 konrad.dybcio@...aro.org, rafael@...nel.org, viresh.kumar@...aro.org,
 heikki.krogerus@...ux.intel.com, gregkh@...uxfoundation.org,
 kees@...nel.org, tony.luck@...el.com, gpiccoli@...lia.com,
 sudeep.holla@....com, quic_rjendra@...cinc.com, andre.przywara@....com,
 ulf.hansson@...aro.org, davidwronek@...il.com, neil.armstrong@...aro.org,
 heiko.stuebner@...rry.de, rafal@...ecki.pl, macromorgan@...mail.com,
 linus.walleij@...aro.org, dmitry.baryshkov@...aro.org,
 johan+linaro@...nel.org, javier.carrasco.cruz@...il.com,
 quic_kriskura@...cinc.com, lpieralisi@...nel.org, fekz115@...il.com
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-usb@...r.kernel.org, linux-hardening@...r.kernel.org,
 linux@...nlining.org
Subject: Re: [PATCH 06/11] usb: typec: ucsi: Add qcom,sm7325-pmic-glink as
 needing PDOS quirk

On 29/07/2024 22:18, Danila Tikhonov wrote:
> The SM7325 Linux Android firmware needs this workaround as well. Add it
> to the list.
> 
> Signed-off-by: Danila Tikhonov <danila@...xyga.com>
> ---
>  drivers/usb/typec/ucsi/ucsi_glink.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi_glink.c b/drivers/usb/typec/ucsi/ucsi_glink.c
> index 16c328497e0b..80fb04473617 100644
> --- a/drivers/usb/typec/ucsi/ucsi_glink.c
> +++ b/drivers/usb/typec/ucsi/ucsi_glink.c
> @@ -294,6 +294,7 @@ static const struct of_device_id pmic_glink_ucsi_of_quirks[] = {
>  	{ .compatible = "qcom,qcm6490-pmic-glink", .data = &quirk_sc8280xp, },
>  	{ .compatible = "qcom,sc8180x-pmic-glink", .data = &quirk_sc8180x, },
>  	{ .compatible = "qcom,sc8280xp-pmic-glink", .data = &quirk_sc8280xp, },
> +	{ .compatible = "qcom,sm7325-pmic-glink", .data = &quirk_sc8280xp, },

Let's don't grow any of such lists without need. Use proper fallbacks,
if that's applicable.

Best regards,
Krzysztof