linux-kernel - Re: [PATCH 11/11] arm64: dts: qcom: sm7325: Add device-tree for Nothing Phone 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e79d848-b1f0-4d56-b5cb-5fcf80868138@kernel.org>
Date: Tue, 30 Jul 2024 11:07:33 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Danila Tikhonov <danila@...xyga.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, andersson@...nel.org,
 konrad.dybcio@...aro.org, rafael@...nel.org, viresh.kumar@...aro.org,
 heikki.krogerus@...ux.intel.com, gregkh@...uxfoundation.org,
 kees@...nel.org, tony.luck@...el.com, gpiccoli@...lia.com,
 sudeep.holla@....com, quic_rjendra@...cinc.com, andre.przywara@....com,
 ulf.hansson@...aro.org, davidwronek@...il.com, neil.armstrong@...aro.org,
 heiko.stuebner@...rry.de, rafal@...ecki.pl, macromorgan@...mail.com,
 linus.walleij@...aro.org, dmitry.baryshkov@...aro.org,
 johan+linaro@...nel.org, javier.carrasco.cruz@...il.com,
 quic_kriskura@...cinc.com, lpieralisi@...nel.org, fekz115@...il.com
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-usb@...r.kernel.org, linux-hardening@...r.kernel.org,
 linux@...nlining.org
Subject: Re: [PATCH 11/11] arm64: dts: qcom: sm7325: Add device-tree for
 Nothing Phone 1

On 29/07/2024 22:18, Danila Tikhonov wrote:
> From: Eugene Lepshy <fekz115@...il.com>
> 
> Add device tree for the Nothing Phone 1 (nothing,spacewar) smartphone
> which is based on the SM7325 SoC.

...

> +
> +&i2c2 {
> +	clock-frequency = <100000>;
> +	status = "okay";
> +
> +	/* nxp,tfa9873 (EAR speaker codec) @ 34 */
> +	/* nxp,tfa9873 (Main speaker codec) @ 35 */
> +};
> +
> +&i2c9 {
> +	clock-frequency = <1000000>;
> +	status = "okay";
> +
> +	nfc@28 {
> +		compatible = "nxp,nxp-nci-i2c";

Prepend it with proper compatible for this NFC chip and update the bindings.

> +		reg = <0x28>;
> +
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <41 IRQ_TYPE_NONE>;

This does not look like valid interrupt type...



Best regards,
Krzysztof