linux-kernel - Re: [EXTERNAL] Re: [PATCH v11 4/9] spi: cadence: Add Marvell SDMA operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUbTm++Vcf8f-wAnHgXF4wgJydE3dAn2hO0oAiTtMkouQ@mail.gmail.com>
Date: Tue, 30 Jul 2024 12:12:19 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Witold Sadowski <wsadowski@...vell.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "broonie@...nel.org" <broonie@...nel.org>, 
	"robh@...nel.org" <robh@...nel.org>, 
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>, 
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "pthombar@...ence.com" <pthombar@...ence.com>
Subject: Re: [EXTERNAL] Re: [PATCH v11 4/9] spi: cadence: Add Marvell SDMA operations

Hi Witold,

On Tue, Jul 30, 2024 at 12:06 PM Witold Sadowski <wsadowski@...vell.com> wrote:
> > drivers/spi/spi-cadence-xspi.c:612:33: error: implicit declaration of
> > function 'readq'; did you mean 'readb'?
> > [-Werror=implicit-function-declaration]
> > drivers/spi/spi-cadence-xspi.c:638:25: error: implicit declaration of
> > function 'writeq'; did you mean 'writel'?
> > [-Werror=implicit-function-declaration]
> >
> >
> > readq() and writeq() are not available on 32-bit platforms, so this
> > driver has to
> > depend on 64BIT (for compile-testing).
> >
> > > +                       *buffer++ = b;
> > > +               } while (--full_ops);
> > > +       }
>
> How can I limit that driver for 64bit test only?

drivers/spi/Kconfig, config SPI_CADENCE_XSPI:

  -depends on OF && HAS_IOMEM
  +depends on OF && HAS_IOMEM && 64BIT

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds