linux-kernel - Re: [PATCH net-next] net: wangxun: use net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c2f124e-3eab-4a24-b801-50c36775e6e4@intel.com>
Date: Tue, 30 Jul 2024 12:16:09 +0200
From: Wojciech Drewek <wojciech.drewek@...el.com>
To: Joe Damato <jdamato@...tly.com>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>
CC: Jiawen Wu <jiawenwu@...stnetic.com>, Mengyuan Lou
	<mengyuanlou@...-swift.com>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Duanqiang Wen
	<duanqiangwen@...-swift.com>
Subject: Re: [PATCH net-next] net: wangxun: use net_prefetch to simplify logic



On 29.07.2024 17:26, Joe Damato wrote:
> Use net_prefetch to remove #ifdef and simplify prefetch logic. This
> follows the pattern introduced in a previous commit f468f21b7af0 ("net:
> Take common prefetch code structure into a function"), which replaced
> the same logic in all existing drivers at that time.
> 
> Signed-off-by: Joe Damato <jdamato@...tly.com>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>

>  drivers/net/ethernet/wangxun/libwx/wx_lib.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/wangxun/libwx/wx_lib.c b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> index 1eecba984f3b..2b3d6586f44a 100644
> --- a/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> @@ -251,10 +251,7 @@ static struct sk_buff *wx_build_skb(struct wx_ring *rx_ring,
>  				  rx_buffer->page_offset;
>  
>  		/* prefetch first cache line of first page */
> -		prefetch(page_addr);
> -#if L1_CACHE_BYTES < 128
> -		prefetch(page_addr + L1_CACHE_BYTES);
> -#endif
> +		net_prefetch(page_addr);
>  
>  		/* allocate a skb to store the frags */
>  		skb = napi_alloc_skb(&rx_ring->q_vector->napi, WX_RXBUFFER_256);