linux-kernel - Re: [PATCH v2 1/6] rust: module: add static pointer to `{init,cleanup}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240730121806.7191f3fd@eugeo>
Date: Tue, 30 Jul 2024 12:18:06 +0100
From: Gary Guo <gary@...yguo.net>
To: Miguel Ojeda <ojeda@...nel.org>
Cc: a.hindborg@...sung.com, alex.gaynor@...il.com, aliceryhl@...gle.com,
 benno.lossin@...ton.me, bjorn3_gh@...tonmail.com, boqun.feng@...il.com,
 bp@...en8.de, dave.hansen@...ux.intel.com, hpa@...or.com,
 jpoimboe@...nel.org, linux-kernel@...r.kernel.org, masahiroy@...nel.org,
 mingo@...hat.com, nathan@...nel.org, nicolas@...sle.eu,
 patches@...ts.linux.dev, peterz@...radead.org,
 rust-for-linux@...r.kernel.org, tglx@...utronix.de, wedsonaf@...il.com,
 x86@...nel.org
Subject: Re: [PATCH v2 1/6] rust: module: add static pointer to
 `{init,cleanup}_module()`

On Thu, 25 Jul 2024 19:47:13 +0200
Miguel Ojeda <ojeda@...nel.org> wrote:

> On Wed, 24 Jul 2024 20:46:49 +0100 Gary Guo <gary@...yguo.net> wrote:
> >
> > Should this be in section `.discard.addressable` instead?  
> 
> No, we need to mimic the call to `___ADDRESSABLE()` (i.e. the one with
> 3 underscores, not 2), which passes `__{init,exit}data`.
> 
> By the way, thanks for the reviews Gary!
> 
> Cheers,
> Miguel

You're right. It's a bit difficult to navigate macros :)

In this case I think this indeed matches the C implementation.

Reviewed-by: Gary Guo <gary@...yguo.net>

Thanks,
Gary