linux-kernel - Re: [PATCH] wifi: plfxlc: remove assert for mac->lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tencent_48A8AECCEEC30C8EE7C8C6F692C2064D4906@qq.com>
Date: Tue, 30 Jul 2024 19:46:50 +0800
From: Edward Adam Davis <eadavis@...com>
To: kvalo@...nel.org
Cc: eadavis@...com,
	linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org,
	linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org,
	srini.raju@...elifi.com,
	syzbot+51a42f7c2e399392ea82@...kaller.appspotmail.com,
	syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH] wifi: plfxlc: remove assert for mac->lock

On Tue, 30 Jul 2024 13:35:07 +0300, Kalle Valo wrote:
> > syzbot report WARNING in plfxlc_mac_release, according to the context,
> > there is not need assert for mac->lock.
> 
> The commit message should explain _why_ the assert is not needed.
> Otherwise it looks that you are randomly removing it to get rid of the
> warning.
mac->lock is used to protect mac data, but after calling plfxlc_mac_release(), 
there are two functions:ieee80211_unregister_hw() and ieee80211_free_hw(),
there is no action to operate on mac data in these two functions, so mac->lock
is not required.

On the other hand, there is no holding action for mac->lock before calling plfxlc_mac_release.

--
Edward