linux-kernel - Re: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Move tas2563_dvc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8ce11fd-ff6a-4ca0-ac33-5abf20cf242d@sirena.org.uk>
Date: Tue, 30 Jul 2024 13:27:24 +0100
From: Mark Brown <broonie@...nel.org>
To: "Ding, Shenghao" <shenghao-ding@...com>
Cc: "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"perex@...ex.cz" <perex@...ex.cz>,
	"pierre-louis.bossart@...ux.intel.com" <pierre-louis.bossart@...ux.intel.com>,
	"13916275206@....com" <13916275206@....com>,
	"zhourui@...qin.com" <zhourui@...qin.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"Salazar, Ivan" <i-salazar@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Chadha, Jasjot Singh" <j-chadha@...com>,
	"liam.r.girdwood@...el.com" <liam.r.girdwood@...el.com>,
	"Yue, Jaden" <jaden-yue@...com>,
	"yung-chuan.liao@...ux.intel.com" <yung-chuan.liao@...ux.intel.com>,
	"Rao, Dipa" <dipa@...com>,
	"yuhsuan@...gle.com" <yuhsuan@...gle.com>,
	"Lo, Henry" <henry.lo@...com>, "tiwai@...e.de" <tiwai@...e.de>,
	"Xu, Baojun" <baojun.xu@...com>, "soyer@....hu" <soyer@....hu>,
	"Baojun.Xu@....com" <Baojun.Xu@....com>,
	"judyhsiao@...gle.com" <judyhsiao@...gle.com>,
	"Navada Kanyana, Mukund" <navada@...com>,
	"cujomalainey@...gle.com" <cujomalainey@...gle.com>,
	"Kutty, Aanya" <aanya@...com>,
	"Mahmud, Nayeem" <nayeem.mahmud@...com>,
	"savyasanchi.shukla@...radyne.com" <savyasanchi.shukla@...radyne.com>,
	"flaviopr@...rosoft.com" <flaviopr@...rosoft.com>,
	"Ji, Jesse" <jesse-ji@...com>,
	"darren.ye@...iatek.com" <darren.ye@...iatek.com>,
	"antheas.dk@...il.com" <antheas.dk@...il.com>
Subject: Re: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Move tas2563_dvc_table
 into a separate Header file

On Tue, Jul 30, 2024 at 01:24:34AM +0000, Ding, Shenghao wrote:

> One more thing, these day my colleague and I want have some adjustment on the 
> tas2781 driver code to support both i2c and spi interface, and plan to abstract
> the common part, especially the dsp binary parsing, as a shared lib. Would you
> be so kind and give us some advice on it? Thanks.

That seems like a sensible and reasonable design - factoring out common
code is a good idea, there's a number of existing drivers doing things
ike that.  Possibly the biggest example is the Cirrus/Wolfson Arizona
drivers and the wm_adsp DSPs they use.  Do you have specific questions
around this?

Download attachment "signature.asc" of type "application/pgp-signature" (485 bytes)