linux-kernel - Re: [PATCH V2 0/2] uapi: Add support for GENMASK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <79960e1a-6fa1-4d15-b842-0dc4d6a2bc1b@app.fastmail.com>
Date: Tue, 30 Jul 2024 14:29:44 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Anshuman Khandual" <anshuman.khandual@....com>,
 linux-kernel@...r.kernel.org
Cc: "Andrew Morton" <akpm@...ux-foundation.org>,
 "Yury Norov" <yury.norov@...il.com>,
 "Rasmus Villemoes" <linux@...musvillemoes.dk>,
 Linux-Arch <linux-arch@...r.kernel.org>, "Ard Biesheuvel" <ardb@...nel.org>
Subject: Re: [PATCH V2 0/2] uapi: Add support for GENMASK_U128()

On Tue, Jul 30, 2024, at 06:29, Anshuman Khandual wrote:
> On 7/25/24 11:18, Anshuman Khandual wrote:
>> 
>> - Wrapped genmask_u128_test() with CONFIG_ARCH_SUPPORTS_INT128
>> - Defined __BITS_PER_U128 unconditionally as 128
>> - Defined __GENMASK_U128() via new _BIT128()
>> - Dropped _U128() and _AC128()
>
> Does the changed series look good ? Please do let me know if something
> further needs to be changed. Thank you.

Yes, these look fine to me, please add

Reviewed-by: Arnd Bergmann <arnd@...db.de>

One detail: You are not actually using __BITS_PER_U128 at
all now, so I think it would be better to not add it at all.