[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240730124631.GL1552@pendragon.ideasonboard.com>
Date: Tue, 30 Jul 2024 15:46:31 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: Julien Stephan <jstephan@...libre.com>,
Andy Hsieh <andy.hsieh@...iatek.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org,
Phi-bang Nguyen <pnguyen@...libre.com>
Subject: Re: [PATCH v6 2/5] dt-bindings: media: add mediatek ISP3.0 camsv
On Mon, Jul 29, 2024 at 04:57:36PM +0200, AngeloGioacchino Del Regno wrote:
> Il 29/07/24 16:48, Julien Stephan ha scritto:
> > From: Phi-bang Nguyen <pnguyen@...libre.com>
> >
> > This adds the bindings, for the ISP3.0 camsv module embedded in
> > some Mediatek SoC, such as the mt8365
> >
> > Signed-off-by: Phi-bang Nguyen <pnguyen@...libre.com>
> > Signed-off-by: Julien Stephan <jstephan@...libre.com>
> > ---
> > .../bindings/media/mediatek,mt8365-camsv.yaml | 109 +++++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 110 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8365-camsv.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8365-camsv.yaml
> > new file mode 100644
> > index 000000000000..fdd076756459
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8365-camsv.yaml
> > @@ -0,0 +1,109 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright (c) 2023 MediaTek, BayLibre
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/mediatek,mt8365-camsv.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek CAMSV 3.0
>
> Sorry, can we unroll the "CAMSV" acronym?
>
> Is that CAMera Sensor V(what?) or anything similar?
If someone can tell us what CAMSV stands for, yes :-) I don't know
personally, and I don't think Julien knows either.
> > +
> > +maintainers:
> > + - Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > + - Julien Stephan <jstephan@...libre.com>
> > + - Andy Hsieh <andy.hsieh@...iatek.com>
> > +
> > +description:
> > + The CAMSV is a video capture device that includes a DMA engine connected to
> > + the SENINF CSI-2 receivers. The number of CAMSVs depend on the SoC model.
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt8365-camsv
> > +
> > + reg:
> > + items:
> > + - description: camsv base
> > + - description: img0 base
> > + - description: tg base
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > + clocks:
> > + items:
> > + - description: cam clock
> > + - description: camtg clock
> > + - description: camsv clock
> > +
> > + clock-names:
> > + items:
> > + - const: cam
> > + - const: camtg
> > + - const: camsv
> > +
> > + iommus:
> > + maxItems: 1
> > +
> > + ports:
> > + $ref: /schemas/graph.yaml#/properties/ports
> > +
> > + properties:
> > + port@0:
> > + $ref: /schemas/graph.yaml#/properties/port
> > + description: Connection to the SENINF output
> > +
> > + required:
> > + - port@0
> > +
> > +required:
> > + - compatible
> > + - interrupts
> > + - clocks
> > + - clock-names
> > + - power-domains
> > + - iommus
> > + - ports
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > + #include <dt-bindings/clock/mediatek,mt8365-clk.h>
> > + #include <dt-bindings/memory/mediatek,mt8365-larb-port.h>
> > + #include <dt-bindings/power/mediatek,mt8365-power.h>
> > +
> > + soc {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + camsv@...50000 {
> > + compatible = "mediatek,mt8365-camsv";
> > + reg = <0 0x15050000 0 0x0040>,
> > + <0 0x15050208 0 0x0020>,
> > + <0 0x15050400 0 0x0100>;
> > + interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&camsys CLK_CAM>,
> > + <&camsys CLK_CAMTG>,
> > + <&camsys CLK_CAMSV0>;
> > + clock-names = "cam", "camtg", "camsv";
> > + iommus = <&iommu M4U_PORT_CAM_IMGO>;
> > + power-domains = <&spm MT8365_POWER_DOMAIN_CAM>;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + port@0 {
> > + reg = <0>;
> > + camsv1_endpoint: endpoint {
> > + remote-endpoint = <&seninf_camsv1_endpoint>;
> > + };
> > + };
> > + };
> > + };
> > + };
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 6bd7df1c3e08..9ac8c08ba692 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -14163,6 +14163,7 @@ M: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > M: Julien Stephan <jstephan@...libre.com>
> > M: Andy Hsieh <andy.hsieh@...iatek.com>
> > S: Supported
> > +F: Documentation/devicetree/bindings/media/mediatek,mt8365-camsv.yaml
> > F: Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml
> >
> > MEDIATEK SMI DRIVER
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists