linux-kernel - Re: remove the dma_set_{max_seg_size,seg_boundary,min_align

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a86ca03d-13ab-4304-879d-ac4cbacabfa5@arm.com>
Date: Tue, 30 Jul 2024 14:13:18 +0100
From: Robin Murphy <robin.murphy@....com>
To: Christoph Hellwig <hch@....de>,
 Marek Szyprowski <m.szyprowski@...sung.com>
Cc: iommu@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: remove the dma_set_{max_seg_size,seg_boundary,min_align_mask}
 return value

On 23/07/2024 1:05 am, Christoph Hellwig wrote:
> Hi all,
> 
> the above three functions can only return errors if the bus code failed
> to allocate the dma_parms structure, which is a grave error that won't
> get us far.  Thus remove the pointless return values, that so far have
> fortunately been mostly ignored, but which the cleanup brigade now wants
> to check for for no good reason.
> 
> I'd love to get this in after -rc1 so that we can catch any of those
> cleanups that might be queued up for this merge window.

Indeed, I think this is long overdue ever since the responsibility for 
dma_parms was moved from these callers into bus code. For the series,

Reviewed-by: Robin Murphy <robin.murphy@....com>