linux-kernel - Re: [PATCH v2] arm64: dts: mediatek: mt8195: Add SCP phandle to MDP3 DMA controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9820b8cb-2443-4085-a18a-264da51e0a08@notapiano>
Date: Tue, 30 Jul 2024 09:20:46 -0400
From: Nícolas F. R. A. Prado <nfraprado@...labora.com>
To: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Moudy Ho <moudy.ho@...iatek.com>
Cc: kernel@...labora.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2] arm64: dts: mediatek: mt8195: Add SCP phandle to MDP3
 DMA controller

On Thu, Jun 06, 2024 at 05:12:04PM -0400, Nícolas F. R. A. Prado wrote:
> While the MDP3 DMA controller can look for the SCP node based on
> compatible, it's best practice to supply the MDP3 node with a phandle to
> the SCP since that allows supporting dual core SCP as well. Besides,
> relying on the compatible search causes an error to be printed, since
> the phandle is tried first:
> 
>   mtk-mdp3 14001000.dma-controller: can't get SCP node
> 
> Add the missing phandle to follow the best practice and get rid of the
> error.
> 
> Fixes: 5710462a116c ("arm64: dts: mediatek: mt8195: add MDP3 nodes")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>

Hi Angelo,

I already asked in another patch, but in case that was missed: It seems this
patch was missed. Do you want me to resend it?

Thanks,
Nícolas