linux-kernel - Re: [PATCH v1] mm/hugetlb: remove hugetlb_follow_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZqpSg2c3r98rBvUH@x1n>
Date: Wed, 31 Jul 2024 11:04:35 -0400
From: Peter Xu <peterx@...hat.com>
To: David Hildenbrand <david@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	linux-fsdevel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Muchun Song <muchun.song@...ux.dev>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH v1] mm/hugetlb: remove hugetlb_follow_page_mask() leftover

On Wed, Jul 31, 2024 at 04:20:00PM +0200, David Hildenbrand wrote:
> We removed hugetlb_follow_page_mask() in commit 9cb28da54643 ("mm/gup:
> handle hugetlb in the generic follow_page_mask code") but forgot to
> cleanup some leftovers.
> 
> While at it, simplify the hugetlb comment, it's overly detailed and
> rather confusing. Stating that we may end up in there during coredumping
> is sufficient to explain the PF_DUMPCORE usage.
> 
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Peter Xu <peterx@...hat.com>
> Cc: Muchun Song <muchun.song@...ux.dev>
> Cc: Alexander Viro <viro@...iv.linux.org.uk>
> Cc: Christian Brauner <brauner@...nel.org>
> Cc: Jan Kara <jack@...e.cz>
> Signed-off-by: David Hildenbrand <david@...hat.com>

Reviewed-by: Peter Xu <peterx@...hat.com>

-- 
Peter Xu