linux-kernel - Re: [PATCH v4 0/2] coresight: core: Add device name support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ9a7VhwD6kFHPTgrfs+7fNx4nXZPqXTLK0ObmJM3A6mQfmuyQ@mail.gmail.com>
Date: Wed, 31 Jul 2024 16:15:02 +0100
From: Mike Leach <mike.leach@...aro.org>
To: Mao Jinlong <quic_jinlmao@...cinc.com>
Cc: Suzuki K Poulose <suzuki.poulose@....com>, James Clark <james.clark@....com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, coresight@...ts.linaro.org, 
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	Tingwei Zhang <quic_tingweiz@...cinc.com>, Yuanfang Zhang <quic_yuanfang@...cinc.com>, 
	Tao Zhang <quic_taozha@...cinc.com>, songchai <quic_songchai@...cinc.com>, 
	Jie Gan <quic_jiegan@...cinc.com>
Subject: Re: [PATCH v4 0/2] coresight: core: Add device name support

Hi,

1) As per Krzysztof comment - use the standard "label" property

2) Do not use the label string as the node name - there is no
guarantee of uniqueness which will cause issues. Please add the label
as a sysfs file to the standard node.
This uses the existing standard names, allowing any scripting based on
this to continue to work, and will not cause issues with uniqueness

e.g.
This will allow :

cat cti_cpu0/label

to extract the additional hardware context information that you need.

Thanks

Mike


On Wed, 3 Jul 2024 at 13:24, Mao Jinlong <quic_jinlmao@...cinc.com> wrote:
>
> With current design, the name of the non-cpu bounded coresight
> component is the device type with the number. And with 'ls' command
> we can get the register address of the component. But from these
> information, we can't know what the HW or system the component belongs
> to. Add device-name in DT to support it.
>
> cti_sys0 -> ../../../devices/platform/soc@...38f0000.cti/cti_sys0
> cti_sys1 -> ../../../devices/platform/soc@...3900000.cti/cti_sys1
> tpdm0 -> ../../../devices/platform/soc@...0b0d000.tpdm/tpdm0
> tpdm1 -> ../../../devices/platform/soc@...0c28000.tpdm/tpdm1
> tpdm2 -> ../../../devices/platform/soc@...0c29000.tpdm/tpdm2
>
> Change since V3:
> 1. Change device-name to arm,cs-dev-name.
> 2. Add arm,cs-dev-name to only CTI and sources' dt-binding.
>
> Change since V2:
> 1. Fix the error in coresight core.
> drivers/hwtracing/coresight/coresight-core.c:1775:7: error: assigning to 'char *' from 'const char *' discards qualifiers
>
> 2. Fix the warning when run dtbinding check.
> Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml: device-name: missing type definition
>
> Change since V1:
> 1. Change coresight-name to device name.
> 2. Add the device-name in coresight dt bindings.
>
>
> Mao Jinlong (2):
>   coresight: core: Add device name support
>   dt-bindings: arm: Add device-name in the coresight components
>
>  .../bindings/arm/arm,coresight-catu.yaml      |  6 +++
>  .../bindings/arm/arm,coresight-cpu-debug.yaml |  6 +++
>  .../bindings/arm/arm,coresight-cti.yaml       |  6 +++
>  .../arm/arm,coresight-dummy-sink.yaml         |  6 +++
>  .../arm/arm,coresight-dummy-source.yaml       |  6 +++
>  .../arm/arm,coresight-dynamic-funnel.yaml     |  6 +++
>  .../arm/arm,coresight-dynamic-replicator.yaml |  6 +++
>  .../bindings/arm/arm,coresight-etb10.yaml     |  6 +++
>  .../bindings/arm/arm,coresight-etm.yaml       |  6 +++
>  .../arm/arm,coresight-static-funnel.yaml      |  6 +++
>  .../arm/arm,coresight-static-replicator.yaml  |  6 +++
>  .../bindings/arm/arm,coresight-stm.yaml       |  6 +++
>  .../bindings/arm/arm,coresight-tmc.yaml       |  6 +++
>  .../bindings/arm/arm,coresight-tpiu.yaml      |  6 +++
>  .../bindings/arm/qcom,coresight-tpda.yaml     |  6 +++
>  .../bindings/arm/qcom,coresight-tpdm.yaml     |  6 +++
>  drivers/hwtracing/coresight/coresight-core.c  | 37 ++++++++++---------
>  .../hwtracing/coresight/coresight-platform.c  | 31 ++++++++++++++++
>  include/linux/coresight.h                     |  3 +-
>  19 files changed, 149 insertions(+), 18 deletions(-)
>
> Mao Jinlong (2):
>   dt-bindings: arm: Add device-name in the coresight components
>   coresight: core: Add device name support
>
>  .../bindings/arm/arm,coresight-cti.yaml       |  6 +++
>  .../arm/arm,coresight-dummy-source.yaml       |  6 +++
>  .../bindings/arm/arm,coresight-stm.yaml       |  6 +++
>  .../bindings/arm/qcom,coresight-tpdm.yaml     |  6 +++
>  drivers/hwtracing/coresight/coresight-core.c  | 37 ++++++++++---------
>  .../hwtracing/coresight/coresight-platform.c  | 30 +++++++++++++++
>  include/linux/coresight.h                     |  3 +-
>  7 files changed, 76 insertions(+), 18 deletions(-)
>
> --
> 2.41.0
>


--
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK