linux-kernel - Re: [PATCH] x86/cpufeatures: SGX: Adjust the error message when BIOS does not support SGX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4453C8E00ABF5220+5cc48da4-637f-437f-abc8-5183399fc414@uniontech.com>
Date: Wed, 31 Jul 2024 11:22:24 +0800
From: WangYuli <wangyuli@...ontech.com>
To: "Huang, Kai" <kai.huang@...el.com>, "seanjc@...gle.com"
 <seanjc@...gle.com>, "bp@...en8.de" <bp@...en8.de>,
 "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
 "hpa@...or.com" <hpa@...or.com>, "tglx@...utronix.de" <tglx@...utronix.de>,
 "mingo@...hat.com" <mingo@...hat.com>,
 "xiangzelong@...ontech.com" <xiangzelong@...ontech.com>
Cc: "baimingcong@...ontech.com" <baimingcong@...ontech.com>,
 "linux-sgx@...r.kernel.org" <linux-sgx@...r.kernel.org>,
 "jarkko@...nel.org" <jarkko@...nel.org>, "x86@...nel.org" <x86@...nel.org>,
 "guanwentao@...ontech.com" <guanwentao@...ontech.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "haitao.huang@...ux.intel.com" <haitao.huang@...ux.intel.com>,
 "wubo@...ontech.com" <wubo@...ontech.com>
Subject: Re: [PATCH] x86/cpufeatures: SGX: Adjust the error message when BIOS
 does not support SGX

On 2024/7/30 19:57, Huang, Kai wrote:

> +linux-sgx list, Jarkko, Haitao.
>
> This message is only printed when SGX is reported in CPUID but is not
> enabled in the FEAT_CTL MSR.  I can only recall this can happen when the
> BIOS actually provides an option for the user to turn on/off SGX, in
> which case the current message is correct.
>
> I could be wrong, but I don't recall I have met any machine that doesn't
> have any SGX option in the BIOS but still reports SGX in the CPUID.  Can
> you confirm this is the case?

Sure.

For example, Lenovo ThinkPad T480s that compliance id is TP00092A.

>
> I don't see this is mentioned in the github link below which reports this
> issue.  In fact, it says:
>
> 	非bug，主板bios关闭了SGX，正常内核提醒
>
> .. which is
>
> 	Not bug, the motherboard BIOS disabled SGX, normal kernel
> message
hah, that's a typo.
>
> And the link also shows this issue is "closed".
>
> Please clarify.
-- 
WangYuli