linux-kernel - Re: [PATCH] alpha: fix ioread64be()/iowrite64be() helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6bd73068-4474-4129-857b-39150a31f224@roeck-us.net>
Date: Wed, 31 Jul 2024 08:47:42 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Richard Henderson <richard.henderson@...aro.org>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Matt Turner <mattst88@...il.com>, Arnd Bergmann <arnd@...db.de>,
	"Paul E. McKenney" <paulmck@...nel.org>,
	Kefeng Wang <wangkefeng.wang@...wei.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Baoquan He <bhe@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
	Breno Leitao <leitao@...ian.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] alpha: fix ioread64be()/iowrite64be() helpers

On Tue, Jul 30, 2024 at 05:27:25PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Compile-testing the crypto/caam driver on alpha showed a pre-existing
> problem on alpha with iowrite64be() missing:
> 
> ERROR: modpost: "iowrite64be" [drivers/crypto/caam/caam_jr.ko] undefined!
> 
> The prototypes were added a while ago when we started using asm-generic/io.h,
> but the implementation was still missing. At some point the ioread64/iowrite64
> helpers were added, but the big-endian versions are still missing, and
> the generic version (using readq/writeq) is would not work here.
> 
> Change it to wrap ioread64()/iowrite64() instead.
> 
> Fixes: beba3771d9e0 ("crypto: caam: Make CRYPTO_DEV_FSL_CAAM dependent of COMPILE_TEST")
> Fixes: e19d4ebc536d ("alpha: add full ioread64/iowrite64 implementation")
> Fixes: 7e772dad9913 ("alpha: Use generic <asm-generic/io.h>")
> Closes: https://lore.kernel.org/all/CAHk-=wgEyzSxTs467NDOVfBSzWvUS6ztcwhiy=M3xog==KBmTw@mail.gmail.com/
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Tested-by: Guenter Roeck <linux@...ck-us.net>

> ---
> I've queued this in the asm-generic tree now, will send a pull request
> in the next few days to fix alpha allmodconfig.
> 
>  arch/alpha/include/asm/io.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/alpha/include/asm/io.h b/arch/alpha/include/asm/io.h
> index 2bb8cbeedf91..52212e47e917 100644
> --- a/arch/alpha/include/asm/io.h
> +++ b/arch/alpha/include/asm/io.h
> @@ -534,8 +534,11 @@ extern inline void writeq(u64 b, volatile void __iomem *addr)
>  
>  #define ioread16be(p) swab16(ioread16(p))
>  #define ioread32be(p) swab32(ioread32(p))
> +#define ioread64be(p) swab64(ioread64(p))
>  #define iowrite16be(v,p) iowrite16(swab16(v), (p))
>  #define iowrite32be(v,p) iowrite32(swab32(v), (p))
> +#define iowrite64be(v,p) iowrite64(swab64(v), (p))
> +
>  

FWIW: Unnecessary extra blank line

Thanks,
Guenter