linux-kernel - Re: [PATCH v2 6/9] mm: Make hugetlb mappings go through mm_get_unmapped_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqpgdBk-3Bcl3Mvr@localhost.localdomain>
Date: Wed, 31 Jul 2024 18:04:04 +0200
From: Oscar Salvador <osalvador@...e.de>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, Peter Xu <peterx@...hat.com>,
	Muchun Song <muchun.song@...ux.dev>,
	David Hildenbrand <david@...hat.com>,
	Donet Tom <donettom@...ux.ibm.com>,
	Matthew Wilcox <willy@...radead.org>,
	Vlastimil Babka <vbabka@...e.cz>, Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH v2 6/9] mm: Make hugetlb mappings go through
 mm_get_unmapped_area_vmflags

On Wed, Jul 31, 2024 at 04:19:09PM +0100, Lorenzo Stoakes wrote:
> Yeah this is at commit aee8efc95fc2 ("mm: make hugetlb mappings go through
> mm_get_unmapped_area_vmflags").
> 
> If you:
> 
> git checkout aee8efc95fc2
> git grep hugetlb_get_unmapped_area
> 
> You'll see it.
> 
> I'm guessing you remove this in future commits, but the kernel must be able
> to build at every revision so we can bisect (I found this issue through a
> bisect and had to fix this up to check).
> 
> A trivial fix is just to provide the prototype immediately prior to the
> function decl, however the more correct solution is probably to do the
> removals at the same time.

Yeah, I just squashed the removal commit and this one.

> This bit is just a bit of a slightly nitty cleanup to make sure things
> build at every commit, the first issue is the really key one, just needs
> some tweaking to deal with the frankly bloody horrible SHM stuff... Do not
> blame you for missing that one!

I did not check closely yet, but are blowing up in:

 if (shmem_huge != SHMEM_HUGE_FORCE) {
         ... 
	 if (file) {
		 VM_BUG_ON(file->f_op != &shmem_file_operations)

 ?  


-- 
Oscar Salvador
SUSE Labs