Message-ID: <2024073104-friction-conjoined-c34a@gregkh>
Date: Wed, 31 Jul 2024 18:10:38 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: EiPiFun <me@...i.fun>
Cc: linux-staging <linux-staging@...ts.linux.dev>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] code indent,
 drivers/staging/rtl8723bs/include/rtw_security.h

On Thu, Aug 01, 2024 at 12:52:54AM +0900, EiPiFun wrote:
> From 816921cbfa76a1cfd0cb1ca93a9df0f2a429bc3a Mon Sep 17 00:00:00 2001
> From: EiPi Fun <me@...i.fun&gt;
> Date: Tue, 30 Jul 2024 07:28:38 +0000
> Subject: [PATCH] code indent should use tabs where possible
> 
> ---
> &nbsp;drivers/staging/rtl8723bs/include/rtw_security.h | 4 ++--
> &nbsp;1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/rtw_security.h
> b/drivers/staging/rtl8723bs/include/rtw_security.h
> index c3e47d526..89c1d5ae1 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_security.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_security.h
> @@ -75,8 +75,8 @@ struct {
> &nbsp;};
> &nbsp;
> &nbsp;union Keytype {
> -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; u8&nbsp;&nbsp; skey[16];
> -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; u32&nbsp;&nbsp;&nbsp; lkey[4];
> +	u8&nbsp;&nbsp; skey[16];
> +	u32&nbsp;&nbsp;&nbsp; lkey[4];
> &nbsp;};
> &nbsp;
> &nbsp;
> -- 
> 2.20.1

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/process/email-clients.rst in order to fix this.

- Your patch was attached, please place it inline so that it can be
  applied directly from the email message itself.

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/process/submitting-patches.rst and resend
  it after adding that line.  Note, the line needs to be in the body of
  the email, before the patch, not at the bottom of the patch or in the
  email signature.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what a proper
  Subject: line should look like.

- It looks like you did not use your name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file,
  Documentation/process/submitting-patches.rst for how to do this
  correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Powered by blists - more mailing lists