lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87h6c55xnp.ffs@tglx>
Date: Wed, 31 Jul 2024 18:33:30 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Marek Maślanka <mmaslanka@...gle.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Rajneesh Bhardwaj
 <irenic.rajneesh@...il.com>, David E Box <david.e.box@...el.com>, Hans de
 Goede <hdegoede@...hat.com>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>, John Stultz <jstultz@...gle.com>, Stephen
 Boyd <sboyd@...nel.org>, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v3] platform/x86:intel/pmc: Enable the ACPI PM Timer to
 be turned off when suspended

Marek!

On Wed, Jul 31 2024 at 16:44, Marek Maślanka wrote:
> On Tue, Jul 30, 2024 at 6:08 PM Thomas Gleixner <tglx@...utronix.de> wrote:
>> On Tue, Jul 30 2024 at 12:05, Marek Maslanka wrote:
>> +static void acpi_pm_disable(struct clocksource *cs)
>> +{
>> +       acpi_pm_enabled = false;
>> +       if (enable_callback)
>> +               enable_callback(false);
>> +}
>> +
>>  static struct clocksource clocksource_acpi_pm = {
>>         .name           = "acpi_pm",
>>         .rating         = 200,
>>         .read           = acpi_pm_read,
>>         .mask           = (u64)ACPI_PM_MASK,
>>         .flags          = CLOCK_SOURCE_IS_CONTINUOUS,
>> +       .enable         = acpi_pm_enable,
>> +       .disable        = acpi_pm_disable,
>>  };
>>
> Thanks. I'll try do this in that way. But I need to disable/enable
> ACPI PM timer only on suspend/resume, so I'll use suspend/resume
> callbacks.

Why? What's the point of keeping it running when nothing uses it?

Thanks,

        tglx

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ