linux-kernel - Re: [PATCH v2] selftests: ksft: Fix finished() helper exit code on skipped tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2a62bb4c-f701-482c-b83d-ec3e489b0f7e@linuxfoundation.org>
Date: Wed, 31 Jul 2024 11:47:52 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>,
 Laura Nao <laura.nao@...labora.com>, shuah@...nel.org
Cc: gregkh@...uxfoundation.org, nfraprado@...labora.com,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel@...labora.com, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] selftests: ksft: Fix finished() helper exit code on
 skipped tests

On 7/31/24 07:05, Muhammad Usama Anjum wrote:
> On 7/30/24 3:29 PM, Laura Nao wrote:
>> The Python finished() helper currently exits with KSFT_FAIL when there
>> are only passed and skipped tests. Fix the logic to exit with KSFT_PASS
>> instead, making it consistent with its C and bash counterparts
>> (ksft_finished() and ktap_finished() respectively).
>>
>> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
>> Fixes: dacf1d7a78bf ("kselftest: Add test to verify probe of devices from discoverable buses")
>> Signed-off-by: Laura Nao <laura.nao@...labora.com>
> Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
> 
>> ---
>> This is a revised version of the patch initially submitted as "[PATCH]
>> selftests: ksft: Track skipped tests when finishing the test suite":
>> https://lore.kernel.org/all/20240722154319.619944-1-laura.nao@collabora.com/
>>
>> Depends on "[PATCH v2 2/3] kselftest: Move ksft helper module to common
>> directory":
>> https://lore.kernel.org/all/20240705-dev-err-log-selftest-v2-2-163b9cd7b3c1@collabora.com/
>> (picked through the usb tree, queued for 6.11-rc1)
>>
>> Changes in v2:
>> - Reworded the commit title and message to more accurately describe the
>> incorrect behavior of the finished() helper addressed by the patch.

Thank you - Applied to linux-kselftest fixes for Linux 6.11-rc2

thanks,
-- Shuah