[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <67e4b306-7a85-5a19-4a89-7820b35a0758@huaweicloud.com>
Date: Wed, 31 Jul 2024 11:53:26 +0800
From: Zhang Yi <yi.zhang@...weicloud.com>
To: Kemeng Shi <shikemeng@...weicloud.com>, tytso@....edu, jack@...e.com
Cc: linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] jbd2: correct comment jbd2_mark_journal_empty
On 2024/7/30 19:33, Kemeng Shi wrote:
> After jbd2_mark_journal_empty, journal log is supposed to be empty.
>
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
Looks good to me.
Reviewed-by: Zhang Yi <yi.zhang@...wei.com>
> ---
> fs/jbd2/journal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index f17d05bc61df..dc18b9f7c999 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -1939,7 +1939,7 @@ static void jbd2_mark_journal_empty(journal_t *journal, blk_opf_t write_flags)
> if (had_fast_commit)
> jbd2_set_feature_fast_commit(journal);
>
> - /* Log is no longer empty */
> + /* Log is empty */
> write_lock(&journal->j_state_lock);
> journal->j_flags |= JBD2_FLUSHED;
> write_unlock(&journal->j_state_lock);
>
Powered by blists - more mailing lists