linux-kernel - Re: [PATCH v3 2/2] Input: ilitek_ts_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZqqJz4Jw8dU7uA7a@google.com>
Date: Wed, 31 Jul 2024 12:00:31 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Francesco Dolcini <francesco@...cini.it>
Cc: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Francesco Dolcini <francesco.dolcini@...adex.com>
Subject: Re: [PATCH v3 2/2] Input: ilitek_ts_i2c - add report id message
 validation

On Fri, Dec 22, 2023 at 07:31:14PM +0100, Francesco Dolcini wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>
> 
> Ilitek touch IC driver answer to plain i2c read request, after it has
> generated an interrupt request, with a report id message starting
> with an identifier and a series of points.
> If a request is sent unsolicited by an interrupt request the answer
> do not contain this identifier.
> Add a test to discard these messages, making the driver robust to
> spurious interrupt requests.
> 
> Fixes: 42370681bd46 ("Input: Add support for ILITEK Lego Series")
> Reviewed-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> ---
> v3: added reviewed by
> ---
>  drivers/input/touchscreen/ilitek_ts_i2c.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/input/touchscreen/ilitek_ts_i2c.c b/drivers/input/touchscreen/ilitek_ts_i2c.c
> index 250133f0d68f..557362490244 100644
> --- a/drivers/input/touchscreen/ilitek_ts_i2c.c
> +++ b/drivers/input/touchscreen/ilitek_ts_i2c.c
> @@ -37,6 +37,8 @@
>  #define ILITEK_TP_CMD_GET_MCU_VER			0x61
>  #define ILITEK_TP_CMD_GET_IC_MODE			0xC0
>  
> +#define ILITEK_TP_I2C_REPORT_ID				0x48
> +
>  #define REPORT_COUNT_ADDRESS				61
>  #define ILITEK_SUPPORT_MAX_POINT			40
>  
> @@ -163,6 +165,11 @@ static int ilitek_process_and_report_v6(struct ilitek_ts_data *ts)
>  		goto err_sync_frame;
>  	}
>  
> +	if (buf[0] != ILITEK_TP_I2C_REPORT_ID) {
> +		dev_err(dev, "get touch info failed. Wrong id: 0x%02X\n", buf[0]);
> +		goto err_sync_frame;

Please rebase and use direct return once you fix the previous patch.

Thanks.

-- 
Dmitry