linux-kernel - Re: [PATCH v2] x86/cpu: Adjust the error message when BIOS does not support SGX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zfpx4a0q.ffs@tglx>
Date: Wed, 31 Jul 2024 21:49:25 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: WangYuli <wangyuli@...ontech.com>, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com, hpa@...or.com, wangyuli@...ontech.com,
 seanjc@...gle.com, xiangzelong@...ontech.com
Cc: x86@...nel.org, linux-kernel@...r.kernel.org, wubo@...ontech.com,
 guanwentao@...ontech.com, baimingcong@...ontech.com,
 linux-sgx@...r.kernel.org, jarkko@...nel.org,
 haitao.huang@...ux.intel.com, Kai Huang <kai.huang@...el.com>
Subject: Re: [PATCH v2] x86/cpu: Adjust the error message when BIOS does not
 support SGX

On Wed, Jul 31 2024 at 23:30, wangyuli@...ontech.com wrote:
> When SGX is not supported by the BIOS, the kernel log still output
> the error 'SGX disabled by BIOS', which can be confusing since
> there might not be an SGX-related option in the BIOS settings.
>
> As a kernel, it's difficult to distinguish between the BIOS not
> supporting SGX and the BIOS supporting SGX but it's disabled.
>
> Therefore, update the error message to
> 'SGX disabled or unsupported by BIOS' to make it easier for those
> reading kernel logs to understand what's happening.
>
> Reported-by: Bo Wu <wubo@...ontech.com>
> Link: https://github.com/linuxdeepin/developer-center/issues/10032
> Reviewed-by: Kai Huang <kai.huang@...el.com>
> Link: https://lore.kernel.org/all/a30f7700c7817b3e7e2f2bdb37d5c10a318b2c3b.camel@intel.com/
> Signed-off-by: Zelong Xiang <xiangzelong@...ontech.com>
> Signed-off-by: WangYuli <wangyuli@...ontech.com>

This Signed-off-by chain is invalid. See:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Thanks,

        tglx