linux-kernel - Re: [PATCH v2] ACPI / PMIC: Remove unneeded check in tps68470_pmic_opregion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeCw3NuPhcafTjV0X=5i-3qH_w8CvW8Lbg2WSWPnecNdg@mail.gmail.com>
Date: Wed, 31 Jul 2024 09:19:46 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Aleksandr Mishin <amishin@...rgos.ru>
Cc: Rajmohan Mani <rajmohan.mani@...el.com>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Len Brown <lenb@...nel.org>, Andy Shevchenko <andy@...nel.org>, 
	Mika Westerberg <mika.westerberg@...ux.intel.com>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH v2] ACPI / PMIC: Remove unneeded check in tps68470_pmic_opregion_probe()

On Wed, Jul 31, 2024 at 12:57 AM Aleksandr Mishin <amishin@...rgos.ru> wrote:
>
> In tps68470_pmic_opregion_probe() pointer 'dev' is compared to NULL which
> is useless.
>
> Fix this issue by removing unneeded check.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.

FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

P.S. In case the first version is already applied feel free to use the
above tag for the modifications that lead to the code as after this
patch.

-- 
With Best Regards,
Andy Shevchenko