linux-kernel - Re: [PATCH 1/4] modpost: remove unused HOST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240731-gainful-smoky-nautilus-f8fdd4@lindesnes>
Date: Wed, 31 Jul 2024 22:43:44 +0200
From: Nicolas Schier <nicolas@...sle.eu>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	Kees Cook <kees@...nel.org>, Nathan Chancellor <nathan@...nel.org>,
	Ben Hutchings <ben@...adent.org.uk>
Subject: Re: [PATCH 1/4] modpost: remove unused HOST_ELFCLASS

On Sat, Jul 27, 2024 at 04:42:01PM +0900, Masahiro Yamada wrote:
> HOST_ELFCLASS is output to elfconfig.h, but it is not used in modpost.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  scripts/mod/mk_elfconfig.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/scripts/mod/mk_elfconfig.c b/scripts/mod/mk_elfconfig.c
> index 680eade89be1..aca96b3aada0 100644
> --- a/scripts/mod/mk_elfconfig.c
> +++ b/scripts/mod/mk_elfconfig.c
> @@ -39,12 +39,6 @@ main(int argc, char **argv)
>  		exit(1);
>  	}
>  
> -	if (sizeof(unsigned long) == 4) {
> -		printf("#define HOST_ELFCLASS ELFCLASS32\n");
> -	} else if (sizeof(unsigned long) == 8) {
> -		printf("#define HOST_ELFCLASS ELFCLASS64\n");
> -	}
> -
>  	endian_test.s = 0x0102;
>  	if (memcmp(endian_test.c, "\x01\x02", 2) == 0)
>  		printf("#define HOST_ELFDATA ELFDATA2MSB\n");
> -- 
> 2.43.0
> 
> 

Reviewed-by: Nicolas Schier <nicolas@...sle.eu>