[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a0c639d1-4f21-47f1-bb66-92f185e828a9@gmail.com>
Date: Wed, 31 Jul 2024 22:50:06 +0200
From: Peter Kästle <xypiie@...il.com>
To: "Rafael J. Wysocki" <rjw@...ysocki.net>,
Linux PM <linux-pm@...r.kernel.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
Linux ACPI <linux-acpi@...r.kernel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>, Lukasz Luba
<lukasz.luba@....com>, Zhang Rui <rui.zhang@...el.com>,
Peter Kaestle <peter@...e.net>, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v1 12/17] platform/x86: acerhdf: Use the .should_bind()
thermal zone callback
Hi Rafael,
On 30.07.24 20:33, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> Make the acerhdf driver use the .should_bind() thermal zone
> callback to provide the thermal core with the information on whether or
> not to bind the given cooling device to the given trip point in the
> given thermal zone. If it returns 'true', the thermal core will bind
> the cooling device to the trip and the corresponding unbinding will be
> taken care of automatically by the core on the removal of the involved
> thermal zone or cooling device.
>
> The previously existing acerhdf_bind() function bound cooling devices
> to thermal trip point 0 only, so the new callback needs to return 'true'
> for trip point 0. However, it is straightforward to observe that trip
> point 0 is an active trip point and the only other trip point in the
> driver's thermal zone is a critical one, so it is sufficient to return
> 'true' from that callback if the type of the given trip point is
> THERMAL_TRIP_ACTIVE.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
Thanks for including me on the review.
I'm working on it, but unfortunately the refactoring of the thermal layer
around gov_bang_bang.c earlier this year broke acerhdf.
This needs some debugging and refactoring. I think I can finish it on
upcoming weekend.
--
--peter;
Powered by blists - more mailing lists