linux-kernel - Re: [PATCH] ufs: Use of_property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c22a8f6b-7004-4fa2-a812-70acb6c047d5@acm.org>
Date: Wed, 31 Jul 2024 14:05:13 -0700
From: Bart Van Assche <bvanassche@....org>
To: "Rob Herring (Arm)" <robh@...nel.org>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ufs: Use of_property_present()

On 7/31/24 12:12 PM, Rob Herring (Arm) wrote:
> Use of_property_present() to test for property presence rather than
> of_find_property(). This is part of a larger effort to remove callers
> of of_find_property() and similar functions. of_find_property() leaks
> the DT struct property and data pointers which is a problem for
> dynamically allocated nodes which may be freed.

Please add a qualifier past the prefix "ufs:" in the patch subject to make
it clear that this patch only modifies the UFS platform driver. Otherwise
this patch looks good to me.

Thanks,

Bart.