linux-kernel - Re: [PATCH] ufs: ufshcd: Use of_property_count_u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c27e1eb8-e5e5-4b3c-a792-c447023709bf@acm.org>
Date: Wed, 31 Jul 2024 14:06:59 -0700
From: Bart Van Assche <bvanassche@....org>
To: "Rob Herring (Arm)" <robh@...nel.org>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ufs: ufshcd: Use of_property_count_u32_elems() to get
 property length

On 7/31/24 1:14 PM, Rob Herring (Arm) wrote:
> Replace of_get_property() with the type specific
> of_property_count_u32_elems() to get the property length.
> 
> This is part of a larger effort to remove callers of of_get_property()
> and similar functions. of_get_property() leaks the DT property data
> pointer which is a problem for dynamically allocated nodes which may
> be freed.

The "ufshcd:" qualifier in the patch subject is confusing. Please change
this into something that unambiguously refers to the platform driver.

Thanks,

Bart.