linux-kernel - Re: [PATCH] selftests: ksft: Track skipped tests when finishing the test suite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cba9b382-84ec-4170-9935-aee7c0042705@linuxfoundation.org>
Date: Wed, 31 Jul 2024 17:04:51 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Laura Nao <laura.nao@...labora.com>
Cc: gregkh@...uxfoundation.org, kernel@...labora.com,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 nfraprado@...labora.com, shuah@...nel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests: ksft: Track skipped tests when finishing the
 test suite

On 7/30/24 04:35, Laura Nao wrote:
> On 7/29/24 22:06, Shuah Khan wrote:
>> On 7/29/24 08:52, Laura Nao wrote:
>>> Hi Shuah,
>>>
>>> On 7/23/24 18:17, Shuah Khan wrote:
>>>> On 7/22/24 09:43, Laura Nao wrote:
>>>>> Consider skipped tests in addition to passed tests when evaluating the
>>>>> overall result of the test suite in the finished() helper.
>>>>>
>>
>> I am finally with you now. Can you please more information in your
>> short log and commit log.
>>
>> Isn't this a bug fix? Current logic before this change will report
>> tests failed if there are any skipped tests?
>>
>> Can you send v2 calling it a fix and explain the problem clearly.
>>
> 
> v2 sent: https://lore.kernel.org/all/20240730102928.33182-1-laura.nao@collabora.com/
>   
>> This isn't problem in this patch, but I am concerned about how
>> simply calling tests passed without calling out skipped tests.
>>
>> This problem could be solved by printing a message at the end of tests
>> for non-zero skipped test conditions to say the coverage could be
>> increased by enabling config options.
>>
> 
> Right. We can send a separate patch to address this.

Yes please. Thank you.

thanks,
-- Shuah