linux-kernel - Re: [PATCH v3] selftest: acct: Add selftest for the acct() syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c9dcf6e5-281e-405f-b592-7df2d1bd56bd@linuxfoundation.org>
Date: Wed, 31 Jul 2024 17:29:43 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Abdulrasaq Lawani <abdulrasaqolawani@...il.com>,
 Shuah Khan <shuah@...nel.org>
Cc: javiercarrascocruz@...il.com, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3] selftest: acct: Add selftest for the acct() syscall

On 7/23/24 04:28, Abdulrasaq Lawani wrote:
> The acct() system call enables or disables process accounting.
> If accounting is turned on, records for each terminating process
> are appended to a specified filename as it terminates. An argument of NULL
> causes accounting to be turned off.
> 
> This patch will add a test for the acct() syscall.
> 
> Signed-off-by: Abdulrasaq Lawani <abdulrasaqolawani@...il.com>
> ---
> Changes in v3:
> - Add geteuid to check if test is ran as root.
> - Simplify error conditions for acct function.
> - Remove unecessary messages.
> - Add more informative messages.
> - Update commit message.
> - Add error test case for file creation failure.
> - Link to v2: https://lore.kernel.org/r/20240630-kselftest-acct-syscall-v2-1-b30bbe2a69cd@gmail.com
> 
> Changes in v2:
> Add testcases to test error conditions.
> Add kselftest function for reporting results.
> 
> - Link to v1: https://lore.kernel.org/r/20240622-kselftest-acct-syscall-v1-1-d270b5be8d37@gmail.com
> ---
>   tools/testing/selftests/Makefile            |  1 +
>   tools/testing/selftests/acct/.gitignore     |  3 ++
>   tools/testing/selftests/acct/Makefile       |  4 ++
>   tools/testing/selftests/acct/acct_syscall.c | 78 +++++++++++++++++++++++++++++
>   4 files changed, 86 insertions(+)
> 
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 9039f3709aff..45a58ef5ad92 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -1,4 +1,5 @@
>   # SPDX-License-Identifier: GPL-2.0
> +TARGETS += acct
>   TARGETS += alsa
>   TARGETS += amd-pstate
>   TARGETS += arm64
> diff --git a/tools/testing/selftests/acct/.gitignore b/tools/testing/selftests/acct/.gitignore
> new file mode 100644
> index 000000000000..7e78aac19038
> --- /dev/null
> +++ b/tools/testing/selftests/acct/.gitignore
> @@ -0,0 +1,3 @@
> +acct_syscall
> +config
> +process_log
> \ No newline at end of file
> diff --git a/tools/testing/selftests/acct/Makefile b/tools/testing/selftests/acct/Makefile
> new file mode 100644
> index 000000000000..ff3e238c5634
> --- /dev/null
> +++ b/tools/testing/selftests/acct/Makefile
> @@ -0,0 +1,4 @@

Missing SPDX-License-Identifier: GPL-2.0

The rest looks good to me. Please send v4 adding the SPDX
to acct/Makefile

thanks,
-- Shuah