linux-kernel - Re: [PATCH] arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a456bde9-e00f-4aed-be28-9874b0d57674@ti.com>
Date: Wed, 31 Jul 2024 11:13:23 +0530
From: Jayesh Choudhary <j-choudhary@...com>
To: Parth Pancholi <parth105105@...il.com>, Nishanth Menon <nm@...com>,
        Vignesh Raghavendra <vigneshr@...com>, Tero Kristo <kristo@...nel.org>,
        Rob
 Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor
 Dooley <conor+dt@...nel.org>
CC: Parth Pancholi <parth.pancholi@...adex.com>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4-main: Correct McASP DMAs

Hello Parth,

Thank you for the patch.

On 30/07/24 15:07, Parth Pancholi wrote:
> From: Parth Pancholi <parth.pancholi@...adex.com>
> 
> Correct the McASP nodes - mcasp3 and mcasp4 with the right
> DMAs thread IDs as per TISCI documentation [1] for J784s4.
> This fixes the related McASPs probe failure due to incorrect
> DMA IDs.
> 
> Link: http://downloads.ti.com/tisci/esd/latest/5_soc_doc/j784s4/psil_cfg.html#psi-l-source-and-destination-thread-ids/ [1]
> Fixes: 5095ec4aa1ea ("arm64: dts: ti: k3-j784s4-main: Add McASP nodes")
> Signed-off-by: Parth Pancholi <parth.pancholi@...adex.com>
> ---
>   arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> index f170f80f00c1..d4ac1c9872a5 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> @@ -2755,7 +2755,7 @@ mcasp3: mcasp@...0000 {
>   		interrupts = <GIC_SPI 550 IRQ_TYPE_LEVEL_HIGH>,
>   			     <GIC_SPI 551 IRQ_TYPE_LEVEL_HIGH>;
>   		interrupt-names = "tx", "rx";
> -		dmas = <&main_udmap 0xc500>, <&main_udmap 0x4500>;
> +		dmas = <&main_udmap 0xc403>, <&main_udmap 0x4403>;
>   		dma-names = "tx", "rx";
>   		clocks = <&k3_clks 268 0>;
>   		clock-names = "fck";
> @@ -2773,7 +2773,7 @@ mcasp4: mcasp@...0000 {
>   		interrupts = <GIC_SPI 552 IRQ_TYPE_LEVEL_HIGH>,
>   			     <GIC_SPI 553 IRQ_TYPE_LEVEL_HIGH>;
>   		interrupt-names = "tx", "rx";
> -		dmas = <&main_udmap 0xc501>, <&main_udmap 0x4501>;
> +		dmas = <&main_udmap 0xc404>, <&main_udmap 0x4404>;
>   		dma-names = "tx", "rx";
>   		clocks = <&k3_clks 269 0>;
>   		clock-names = "fck";
Reviewed-by: Jayesh Choudhary <j-choudhary@...com>


Warm Regards,
Jayesh