linux-kernel - Re: [PATCH v3 8/9] firmware: arm_scmi: Make VirtIO transport a standalone driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08e07522-f1ec-4e2f-9b9d-e7129e1ad228@kernel.org>
Date: Wed, 31 Jul 2024 08:11:21 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Cristian Marussi <cristian.marussi@....com>,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 arm-scmi@...r.kernel.org
Cc: sudeep.holla@....com, james.quinlan@...adcom.com, f.fainelli@...il.com,
 vincent.guittot@...aro.org, etienne.carriere@...com, peng.fan@....nxp.com,
 michal.simek@....com, quic_sibis@...cinc.com, quic_nkela@...cinc.com,
 ptosi@...gle.com, dan.carpenter@...aro.org, souvik.chakravarty@....com,
 "Michael S . Tsirkin" <mst@...hat.com>,
 Igor Skalkin <igor.skalkin@...nsynergy.com>,
 Peter Hilber <peter.hilber@...nsynergy.com>
Subject: Re: [PATCH v3 8/9] firmware: arm_scmi: Make VirtIO transport a
 standalone driver

On 30/07/2024 15:33, Cristian Marussi wrote:
> Make SCMI VirtIO transport a standalone driver that can be optionally
> loaded as a module.
> 

> -const struct scmi_desc scmi_virtio_desc = {
> -	.transport_init = virtio_scmi_init,
> -	.transport_exit = virtio_scmi_exit,
> -	.ops = &scmi_virtio_ops,
> -	/* for non-realtime virtio devices */
> -	.max_rx_timeout_ms = VIRTIO_MAX_RX_TIMEOUT_MS,
> -	.max_msg = 0, /* overridden by virtio_get_max_msg() */
> -	.max_msg_size = VIRTIO_SCMI_MAX_MSG_SIZE,
> -	.atomic_enabled = IS_ENABLED(CONFIG_ARM_SCMI_TRANSPORT_VIRTIO_ATOMIC_ENABLE),
> -};
> +MODULE_ALIAS("scmi-transport-virtio");

Why do you need the alias being almost the same as module name?

Best regards,
Krzysztof