linux-kernel - Re: [PATCH v2] sysctl: simplify the min/max boundary check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240731071904.xiydz3icjslwaxzl@joelS2.panther.com>
Date: Wed, 31 Jul 2024 09:19:04 +0200
From: Joel Granados <j.granados@...sung.com>
To: Wen Yang <wen.yang@...ux.dev>
CC: "Eric W . Biederman" <ebiederm@...ssion.com>, Luis Chamberlain
	<mcgrof@...nel.org>, Kees Cook <keescook@...omium.org>, Christian Brauner
	<brauner@...nel.org>, Dave Young <dyoung@...hat.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] sysctl: simplify the min/max boundary check

On Mon, Jul 15, 2024 at 11:02:23PM +0800, Wen Yang wrote:
> The do_proc_dointvec_minmax_conv_param structure provides the minimum and
> maximum values for doing range checking for the proc_dointvec_minmax()
> handler, while the do_proc_douintvec_minmax_conv_param structure also
> provides the minimum and maximum values for doing range checking for the
> proc_douintvec_minmax()/proc_dou8vec_minmax() handlers.
> 
> To avoid duplicate code, a new do_proc_minmax_conv_param structure has been
> introduced to replace both do_proc_dointvec_minmax_conv_param and
> do_proc_douintvec_minmax_conv_param mentioned above.
> 
> This also prepares for the removal of sysctl_vals and sysctl_long_vals.
> 
> Signed-off-by: Wen Yang <wen.yang@...ux.dev>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Joel Granados <j.granados@...sung.com>
> Cc: Eric W. Biederman <ebiederm@...ssion.com>
> Cc: Christian Brauner <brauner@...nel.org>
> Cc: Dave Young <dyoung@...hat.com>
> Cc: linux-kernel@...r.kernel.org
> ---
>  kernel/sysctl.c | 107 ++++++++++++++++++++++++++----------------------
This does not cleanly apply to current 6.11-rc1. Please send a v3 that
applies to current release. Thx

Best

-- 

Joel Granados