[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdUwATmjM3E7WmwnCK739CwuyZH1w_YVYbroDcWEpzh8ig@mail.gmail.com>
Date: Wed, 31 Jul 2024 09:37:36 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Rob Herring <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Magnus Damm <magnus.damm@...il.com>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>, Arnd Bergmann <arnd@...db.de>,
devicetree@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/7] dt-bindings: fuse: Move renesas,rcar-{efuse,otp}
to nvmem
Hi Rob,
On Tue, Jul 30, 2024 at 6:24 PM Rob Herring <robh@...nel.org> wrote:
> On Fri, Jul 26, 2024 at 03:38:06PM +0200, Geert Uytterhoeven wrote:
> > The R-Car E-FUSE blocks can be modelled better using the nvmem
> > framework.
> >
> > Replace the R-Car V3U example by an R-Car S4-8 ES1.2 example, to show
> > the definition of nvmem cells. While at it, drop unneeded labels from
> > the examples, and fix indentation.
> >
> > Add an entry to the MAINTAINERS file.
> >
> > Reported-by: Arnd Bergmann <arnd@...db.de>
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > ---
> > v3:
> > - New.
> >
> > I would expect that the calib@144 node needs:
> >
> > #nvmem-cell-cells = <0>;
> >
> > but after adding that, "make dt_binding_check" starts complaining:
> >
> > Documentation/devicetree/bindings/nvmem/renesas,rcar-efuse.example.dtb: fuse@...78800: nvmem-layout: 'oneOf' conditional failed, one must be fixed:
> > '#address-cells', '#size-cells', 'calib@...' do not match any of the regexes: 'pinctrl-[0-9]+'
> > Unevaluated properties are not allowed ('nvmem-cell-cells' was unexpected)
>
> Did you want 'nvmem-cell-cells' or '#nvmem-cell-cells'?
Oops, I've been (manually) re-adding and removing it again too many
times during my investigations. "#nvmem-cell-cells", of course.
According to my build logs, I had it right at least once ;-)
> > 'kontron,sl28-vpd' was expected
> > 'onie,tlv-layout' was expected
> > from schema $id: http://devicetree.org/schemas/nvmem/renesas,rcar-efuse.yaml#
> > Documentation/devicetree/bindings/nvmem/renesas,rcar-efuse.example.dtb: fuse@...78800: nvmem-layout: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'calib@...' were unexpected)
> > from schema $id: http://devicetree.org/schemas/nvmem/renesas,rcar-efuse.yaml#
> > Documentation/devicetree/bindings/nvmem/renesas,rcar-efuse.example.dtb: fuse@...78800: Unevaluated properties are not allowed ('nvmem-layout' was unexpected)
> > from schema $id: http://devicetree.org/schemas/nvmem/renesas,rcar-efuse.yaml#
Anyway, with or without the typo, the error message is about the same:
- Unevaluated properties are not allowed ('nvmem-cell-cells' was unexpected)
+ Unevaluated properties are not allowed ('#nvmem-cell-cells' was unexpected)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists