linux-kernel - Re: [PATCH v8 3/3] dmaengine: add driver for Sophgo CV18XX/SG200X dmamux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <IA1PR20MB4953FE2F603D5D23175D724BBBB12@IA1PR20MB4953.namprd20.prod.outlook.com>
Date: Wed, 31 Jul 2024 15:37:57 +0800
From: Inochi Amaoto <inochiama@...look.com>
To: Markus Elfring <Markus.Elfring@....de>, 
	Inochi Amaoto <inochiama@...look.com>, dmaengine@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, Albert Ou <aou@...s.berkeley.edu>, 
	Chen Wang <unicorn_wang@...look.com>, Conor Dooley <conor+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Palmer Dabbelt <palmer@...belt.com>, 
	Paul Walmsley <paul.walmsley@...ive.com>, Rob Herring <robh@...nel.org>, Vinod Koul <vkoul@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, 
	Jingbao Qiu <qiujingbao.dlmu@...il.com>, Jisheng Zhang <jszhang@...nel.org>, 
	Liu Gui <kenneth.liu@...hgo.com>, Yixun Lan <dlan@...too.org>
Subject: Re: [PATCH v8 3/3] dmaengine: add driver for Sophgo CV18XX/SG200X
 dmamux

On Mon, Jul 29, 2024 at 01:38:06PM GMT, Markus Elfring wrote:
> …
> > +++ b/drivers/dma/cv1800-dmamux.c
> > @@ -0,0 +1,259 @@
> …
> > +static void cv1800_dmamux_free(struct device *dev, void *route_data)
> > +{
> …
> > +	unsigned long flags;
> > +
> > +	spin_lock_irqsave(&dmamux->lock, flags);
> …
> > +	spin_unlock_irqrestore(&dmamux->lock, flags);
> …
> 
> Under which circumstances would you become interested to apply a statement
> like “guard(spinlock_irqsave)(&dmamux->lock);”?
> https://elixir.bootlin.com/linux/v6.10.2/source/include/linux/spinlock.h#L574
> 
> Regards,
> Markus

This is very useful and I am pretty intersted, but I am not sure it
is suitable. Could you share some technical detail (or some documents)
about this method?

Regards,
Inochi