| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <d88b8d9e-e005-442a-bbf0-2949dd5dc873@kernel.org>
Date: Wed, 31 Jul 2024 10:05:57 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alexander Stein <alexander.stein@...tq-group.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Fabio Estevam <festevam@...il.com>
Cc: linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: usb: microchip, usb2514: Add USB2517
compatible
On 31/07/2024 09:34, Alexander Stein wrote:
> Am Mittwoch, 31. Juli 2024, 09:32:43 CEST schrieb Krzysztof Kozlowski:
>> On 31/07/2024 09:27, Krzysztof Kozlowski wrote:
>>> On 31/07/2024 09:19, Alexander Stein wrote:
>>>> USB2517 is a 7-port variant of this USB hub. Add an USB compatible
>>>> based on USB vendor & product ID.
>>>>
>>>> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
>>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>
>> Of course assuming there is some user? If so, where?
>
> There is: arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts
> introduced by commit ba9943f47dca1 ("arm64: dts: mba93xxla: Add USB support")
Bindings 1.5 years after you added compatible... checkpatch told you
that you miss bindings that time.
This should be explained in commit msg - you add compatible for a
compatible already present in the kernel.
Best regards,
Krzysztof
Powered by blists - more mailing lists