[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bb696e60-642f-43f1-9ccf-972e1d839bcd@kernel.org>
Date: Wed, 31 Jul 2024 10:16:29 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Hsin-Te Yuan <yuanhsinte@...omium.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2 2/2] dt-bindings: arm64: mediatek: Add
kukui-jacuzzi-cerise board
On 31/07/2024 08:26, Hsin-Te Yuan wrote:
> Cerise is known as ASUS Chromebook CZ1.
> Stern is known as ASUS Chromebook Flip CZ1.
>
> They are almost identical. The only difference is that Cerise is a
> clamshell device without touchscreen and Stern is a convertible device.
>
> Signed-off-by: Hsin-Te Yuan <yuanhsinte@...omium.org>
> ---
> Documentation/devicetree/bindings/arm/mediatek.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 1d4bb50fcd8d..087773a43673 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -146,6 +146,20 @@ properties:
> items:
> - const: google,burnet
> - const: mediatek,mt8183
> + - description: Google Cerise (ASUS Chromebook CZ1)
> + items:
> + - enum:
> + - google,cerise-sku0
> + - google,cerise-rev3-sku0
> + - const: google,cerise
> + - const: mediatek,mt8183
> + - description: Google Stern (ASUS Chromebook Flip CZ1)
> + items:
> + - enum:
> + - google,cerise-sku1
> + - google,cerise-rev3-sku1
> + - const: google,cerise
Why not google,stern? If this is not compatible with cerise and has
different name, I think logical would be to have different compatible -
either here or the first one.
Best regards,
Krzysztof
Powered by blists - more mailing lists