[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2024073100-manor-sworn-7bf2@gregkh>
Date: Wed, 31 Jul 2024 10:30:16 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Michael Grzeschik <m.grzeschik@...gutronix.de>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Daniel Scally <dan.scally@...asonboard.com>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: function: uvc: set req_size once when the
vb2 queue is calculated
On Thu, Apr 04, 2024 at 10:35:01AM +0200, Michael Grzeschik wrote:
> The uvc gadget driver is calculating the req_size on every
> video_enable/alloc_request and is based on the fixed configfs parameters
> maxpacket, maxburst and mult.
>
> As those parameters can not be changed once the gadget is started and
> the same calculation is done already early on the
> vb2_streamon/queue_setup path its save to remove one extra calculation
> and reuse the calculation from uvc_queue_setup for the allocation step.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>
> ---
> drivers/usb/gadget/function/uvc_queue.c | 2 ++
> drivers/usb/gadget/function/uvc_video.c | 15 ++-------------
> 2 files changed, 4 insertions(+), 13 deletions(-)
Is this still needed? If so, can you rebase and resubmit it?
thanks,
greg k-h
Powered by blists - more mailing lists