linux-kernel - Re: [PATCH net v2] net/tcp: Disable TCP-AO static key after RCU grace period

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJwJo6YCJJZgaCEXH5WPpJsEkDPnajWQ4gvXaawPyT9f_cpGsQ@mail.gmail.com>
Date: Wed, 31 Jul 2024 03:01:18 +0100
From: Dmitry Safonov <0x7f454c46@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Dmitry Safonov via B4 Relay <devnull+0x7f454c46.gmail.com@...nel.org>, 
	Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, 
	David Ahern <dsahern@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH net v2] net/tcp: Disable TCP-AO static key after RCU grace period

On Wed, 31 Jul 2024 at 02:37, Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 30 Jul 2024 01:33:17 +0100 Dmitry Safonov via B4 Relay wrote:
> > +     struct hlist_node *n;
> > +
> > +     hlist_for_each_entry_safe(key, n, &ao->head, node)
> > +             total_ao_sk_mem += tcp_ao_sizeof_key(key);
>
> nit:
>
> s/_safe//
>
> no need to safely iterate if we're not modifying the list

Certainly! The keys can't be deleted by another CPU once it's
tcp_ao_destroy_sock(), somehow haven't thought about the iterator
here.
Will send v3.

Thanks,
             Dmitry