linux-kernel - Re: [PATCH 02/15] usb: typec: tcpm/tcpci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqoNoGcCsCwNl1N0@kuha.fi.intel.com>
Date: Wed, 31 Jul 2024 13:10:40 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: André Draszik <andre.draszik@...aro.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Peter Griffin <peter.griffin@...aro.org>,
	Tudor Ambarus <tudor.ambarus@...aro.org>,
	Will McVicker <willmcvicker@...gle.com>,
	Badhri Jagan Sridharan <badhri@...gle.com>, kernel-team@...roid.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/15] usb: typec: tcpm/tcpci_maxim: clarify a comment

On Wed, Jul 10, 2024 at 11:36:09AM +0100, André Draszik wrote:
> We loop while the status is != 0, so rephrase the comment slightly for
> clarity.
> 
> Signed-off-by: André Draszik <andre.draszik@...aro.org>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/tcpm/tcpci_maxim_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim_core.c b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> index eec3bcec119c..87102b4d060d 100644
> --- a/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> +++ b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> @@ -397,7 +397,7 @@ static irqreturn_t max_tcpci_irq(int irq, void *dev_id)
>  	}
>  	while (status) {
>  		irq_return = _max_tcpci_irq(chip, status);
> -		/* Do not return if the ALERT is already set. */
> +		/* Do not return if a (new) ALERT is set (again). */
>  		ret = max_tcpci_read16(chip, TCPC_ALERT, &status);
>  		if (ret < 0)
>  			break;
> 
> -- 
> 2.45.2.803.g4e1b14247a-goog

-- 
heikki