linux-kernel - Re: [PATCH] init/Kconfig: Only block on RANDSTRUCT for RUST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEg-Je_S8hAUg9Gdp7QAOxww2dvV4_OoCTV1pvxMNAAvVkQueQ@mail.gmail.com>
Date: Wed, 31 Jul 2024 06:18:13 -0400
From: Neal Gompa <neal@...pa.dev>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: rust-for-linux@...r.kernel.org, asahi@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>, 
	Hector Martin <marcan@...can.st>, Janne Grunau <j@...nau.net>, Asahi Lina <lina@...hilina.net>
Subject: Re: [PATCH] init/Kconfig: Only block on RANDSTRUCT for RUST

On Wed, Jul 31, 2024 at 4:32 AM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Wed, Jul 31, 2024 at 5:21 AM Neal Gompa <neal@...pa.dev> wrote:
> >
> > When enabling Rust in the kernel, we only need to block on the
> > RANDSTRUCT feature and GCC plugin. The rest of the GCC plugins
> > are reasonably safe to enable.
>
> Yeah, only that one is what we had initially years ago, and then we
> went the easy route since anyway the mixed builds are best effort at
> the moment and GCC plugins could possibly be going away anyway.
>
> Did you test it with the other GCC plugins enabled etc.?
>

When I originally wrote this patch two years ago to get things
working, Fedora used all the GCC plugins, so I was trying to get GCC +
Rust to work while minimizing the delta on build differences. This was
the combination that worked. We've been carrying this patch in the
Asahi tree for a year now. And while Fedora does not currently have
GCC plugins enabled because it caused issues with some third-party
modules (I think it was the NVIDIA driver, but I'm not sure), it was
around long enough for me to know with some confidence that it was
fine this way.

> > +       depends on RANDSTRUCT_NONE
>
> Also, why is this changed?
>

This was mostly because I wanted it to be clearer. The negation didn't
exactly read to me the same way, but that hunk can be dropped if you want.

--
真実はいつも一つ！/ Always, there's only one truth!