linux-kernel - Re: [PATCH v3 02/11] arm64: dts: qcom: sm6115-pro1x: Add PCA9534 IO Expander

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca130fd6-b885-4bbb-9f08-676af8697b8d@linaro.org>
Date: Wed, 31 Jul 2024 13:05:44 +0200
From: Caleb Connolly <caleb.connolly@...aro.org>
To: Dang Huynh <danct12@...eup.net>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 02/11] arm64: dts: qcom: sm6115-pro1x: Add PCA9534 IO
 Expander



On 31/07/2024 08:18, Dang Huynh wrote:
> F(x)tec Pro1X comes with PCA9534 IO Expander, it is used for enabling
> touch screen VDD/VDDIO and keyboard's caps lock LED.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> Signed-off-by: Dang Huynh <danct12@...eup.net>
> ---
>   arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 21 +++++++++++++++++++++
>   1 file changed, 21 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
> index 70f479a63f2e..47e446249af6 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
> @@ -70,6 +70,23 @@ &dispcc {
>   	status = "disabled";
>   };
>   
> +&gpi_dma0 {
> +	status = "okay";
> +};
> +
> +&i2c1 {
> +	status = "okay";
> +	/* Clock frequency was not specified downstream, let's park it to 100 KHz */

This is the default, so you can drop this comment.

Reviewed-by: Caleb Connolly <caleb.connolly@...aro.org>
> +	clock-frequency = <100000>;
> +
> +	pca9534: gpio@21 {
> +		compatible = "nxp,pca9534";
> +		reg = <0x21>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +};
> +
>   &pm6125_gpios {
>   	vol_up_n: vol-up-n-state {
>   		pins = "gpio5";
> @@ -89,6 +106,10 @@ &pon_resin {
>   	status = "okay";
>   };
>   
> +&qupv3_id_0 {
> +	status = "okay";
> +};
> +
>   &rpm_requests {
>   	regulators-0 {
>   		compatible = "qcom,rpm-pm6125-regulators";
> 

-- 
// Caleb (they/them)