linux-kernel - Re: 答复: [PATCH v2] usb: gadget: uvc: Fixes the abnormal enumeration problem of mobile phone as UVC camera.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024073150-pointless-makeshift-3745@gregkh>
Date: Wed, 31 Jul 2024 13:54:10 +0200
From: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To: 胡连勤 <hulianqin@...o.com>
Cc: "laurent.pinchart@...asonboard.com" <laurent.pinchart@...asonboard.com>,
	"dan.scally@...asonboard.com" <dan.scally@...asonboard.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"opensource.kernel" <opensource.kernel@...o.com>
Subject: Re: 答复: [PATCH v2] usb: gadget: uvc: Fixes the abnormal
 enumeration problem of mobile phone as UVC camera.

On Wed, Jul 31, 2024 at 11:49:11AM +0000, 胡连勤 wrote:
> When the phone is connected to the computer to use the webcam function, 
> the phone needs to be enumerated as a uvc camera function.
> 
> Because uvc->func.bind_deactivated is configured as true in the f_uvc 
> driver uvc_alloc function, the usb_gadget_deactivate function is called 
> during the execution of the configfs_composite_bind function to 
> set gadget->deactivated to true, which in turn causes the 
> usb_gadget_connect_locked function to fail to call the corresponding 
> controller pullup operation (such as: dwc3_gadget_pullup, 
> mtu3_gadget_pullup), and the USB cannot be enumerated 
> normally under the uvc function combination.
> 
> After applying this patch, we measured that under the uvc function, 
> the dwc3 controller and the mtu3 controller can be enumerated normally, 
> and the webcam function is normal.
> 
> Fixes this by removing the setting of uvc->func.bind_deactivated to true.
> 
> Signed-off-by: Lianqin Hu <hulianqin@...o.com>
> ---
> v2:
>   - Add "Fixes:" tag on the commit

There  is no fixes tag here :(

Also you have a lot of trailing whitespace on the commit changelog, is
that intentional?

thanks,

greg k-h