linux-kernel - Re: [PATCH net-next v2 4/4] net: axienet: remove unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d73ee99f-db14-4d93-a96a-75ecc8068014@lunn.ch>
Date: Wed, 31 Jul 2024 14:06:55 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Radhey Shyam Pandey <radhey.shyam.pandey@....com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, michal.simek@....com, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	git@....com
Subject: Re: [PATCH net-next v2 4/4] net: axienet: remove unnecessary
 parentheses

On Wed, Jul 31, 2024 at 02:46:07PM +0530, Radhey Shyam Pandey wrote:
> Remove unnecessary parentheses around 'ndev->mtu
> <= XAE_JUMBO_MTU' and 'ndev->mtu > XAE_MTU'. Reported
> by checkpatch.
> 
> CHECK: Unnecessary parentheses around 'ndev->mtu > XAE_MTU'
> +       if ((ndev->mtu > XAE_MTU) &&
> +           (ndev->mtu <= XAE_JUMBO_MTU)) {
> 
> CHECK: Unnecessary parentheses around 'ndev->mtu <= XAE_JUMBO_MTU'
> +       if ((ndev->mtu > XAE_MTU) &&
> +           (ndev->mtu <= XAE_JUMBO_MTU)) {
> 
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@....com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew