linux-kernel - Re: [PATCH] arm64: dts: arm: Add stdout-path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240731131403.54a9443a@donnerap.manchester.arm.com>
Date: Wed, 31 Jul 2024 13:14:03 +0100
From: Andre Przywara <andre.przywara@....com>
To: Debbie Martin <Debbie.Martin@....com>
Cc: liviu.dudau@....com, sudeep.holla@....com, lpieralisi@...nel.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: arm: Add stdout-path

On Tue, 30 Jul 2024 11:37:58 +0100
Debbie Martin <Debbie.Martin@....com> wrote:

> Add stdout-path to the Arm devicetrees to specify the primary console.
> This means that distributions can boot without the need for
> platform-specific command line parameters i.e. they can use earlycon
> with no parameters and no console argument is needed at all.

Looks good to me, and aligns with what the other DTs do:

> Signed-off-by: Debbie Martin <Debbie.Martin@....com>

Reviewed-by: Andre Przywara <andre.przywara@....com>

Cheers,
Andre

> ---
>  arch/arm64/boot/dts/arm/foundation-v8.dtsi | 4 +++-
>  arch/arm64/boot/dts/arm/fvp-base-revc.dts  | 4 +++-
>  arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts | 4 +++-
>  3 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/arm/foundation-v8.dtsi b/arch/arm64/boot/dts/arm/foundation-v8.dtsi
> index 93f1e7c026b8..083be35495b3 100644
> --- a/arch/arm64/boot/dts/arm/foundation-v8.dtsi
> +++ b/arch/arm64/boot/dts/arm/foundation-v8.dtsi
> @@ -18,7 +18,9 @@ / {
>  	#address-cells = <2>;
>  	#size-cells = <2>;
>  
> -	chosen { };
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
>  
>  	aliases {
>  		serial0 = &v2m_serial0;
> diff --git a/arch/arm64/boot/dts/arm/fvp-base-revc.dts b/arch/arm64/boot/dts/arm/fvp-base-revc.dts
> index 85f1c15cc65d..19973ab4ea6b 100644
> --- a/arch/arm64/boot/dts/arm/fvp-base-revc.dts
> +++ b/arch/arm64/boot/dts/arm/fvp-base-revc.dts
> @@ -24,7 +24,9 @@ / {
>  	#address-cells = <2>;
>  	#size-cells = <2>;
>  
> -	chosen { };
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
>  
>  	aliases {
>  		serial0 = &v2m_serial0;
> diff --git a/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts b/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts
> index afdf954206f1..7f7226711d4b 100644
> --- a/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts
> +++ b/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts
> @@ -23,7 +23,9 @@ / {
>  	#address-cells = <2>;
>  	#size-cells = <2>;
>  
> -	chosen { };
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
>  
>  	aliases {
>  		serial0 = &v2m_serial0;