linux-kernel - Re: [PATCH] x86/cpufeatures: SGX: Adjust the error message when BIOS does not support SGX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a30f7700c7817b3e7e2f2bdb37d5c10a318b2c3b.camel@intel.com>
Date: Wed, 31 Jul 2024 12:20:29 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "seanjc@...gle.com" <seanjc@...gle.com>, "bp@...en8.de" <bp@...en8.de>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>, "hpa@...or.com"
	<hpa@...or.com>, "wangyuli@...ontech.com" <wangyuli@...ontech.com>,
	"mingo@...hat.com" <mingo@...hat.com>, "tglx@...utronix.de"
	<tglx@...utronix.de>, "xiangzelong@...ontech.com" <xiangzelong@...ontech.com>
CC: "baimingcong@...ontech.com" <baimingcong@...ontech.com>,
	"linux-sgx@...r.kernel.org" <linux-sgx@...r.kernel.org>, "jarkko@...nel.org"
	<jarkko@...nel.org>, "x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"guanwentao@...ontech.com" <guanwentao@...ontech.com>,
	"haitao.huang@...ux.intel.com" <haitao.huang@...ux.intel.com>,
	"wubo@...ontech.com" <wubo@...ontech.com>
Subject: Re: [PATCH] x86/cpufeatures: SGX: Adjust the error message when BIOS
 does not support SGX

On Wed, 2024-07-31 at 11:22 +0800, WangYuli wrote:
> On 2024/7/30 19:57, Huang, Kai wrote:
> 
> > +linux-sgx list, Jarkko, Haitao.
> > 
> > This message is only printed when SGX is reported in CPUID but is not
> > enabled in the FEAT_CTL MSR.  I can only recall this can happen when the
> > BIOS actually provides an option for the user to turn on/off SGX, in
> > which case the current message is correct.
> > 
> > I could be wrong, but I don't recall I have met any machine that doesn't
> > have any SGX option in the BIOS but still reports SGX in the CPUID.  Can
> > you confirm this is the case?
> 
> Sure.
> 
> For example, Lenovo ThinkPad T480s that compliance id is TP00092A.
> 
> 

Fair enough.  I guess the updated message is slightly better:

Acked-by: Kai Huang <kai.huang@...el.com>

Btw, I think there are some issues in the patch title/changelog.  Please
fix them.

E.g., I think the format of patch title should be:

	x86/cpu: ...

In the changelog please avoid using "we", and please use imperative mode
to describe the change.  More information please see: 

https://docs.kernel.org/process/maintainer-tip.html